Postgres Pro
Downloads
Home   >   mailing lists

Re: Suspicious strcmp() in src/backend/parser/parse_expr.c - Mailing list pgsql-bugs

From Thomas Munro
Subject Re: Suspicious strcmp() in src/backend/parser/parse_expr.c
Date
Msg-id CA+hUKGJScU-ciKbjW_5Xf-sQXbuy8qH0iHSCBL_+2BuW8xSQNg@mail.gmail.com
Whole thread Raw
In response to Re: Suspicious strcmp() in src/backend/parser/parse_expr.c  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Suspicious strcmp() in src/backend/parser/parse_expr.c  (David Rowley <david.rowley@2ndquadrant.com>)
Re: Suspicious strcmp() in src/backend/parser/parse_expr.c  (Michael Paquier <michael@paquier.xyz>)
List pgsql-bugs
Tree view 
On Thu, Apr 11, 2019 at 2:20 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Wed, Apr 10, 2019 at 06:43:32PM -0400, Tom Lane wrote:
> > Indeed.  Considering how much I hate using strcmp's result as a boolean,
> > you'd think I'd have got that right.  Thanks for noticing!
>
> Just a note about those strcmp() calls using a boolean as return
> result in the tree:
> src/backend/commands/lockcmds.c: (!strcmp(rte->eref->aliasname, "old")

Don't look at contrib/spi/refint.c if you value your sanity.

-- 
Thomas Munro
https://enterprisedb.com

pgsql-bugs by date:

Previous
From: Michael Paquier
Date:
Subject: Re: BUG #15734: Walsender process crashing when executing SHOW ALL;
Next
From: r.zharkov@postgrespro.ru
Date:
Subject: Re: BUG #15727: PANIC: cannot abort transaction 295144144, it wasalready committed