Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup
Date
Msg-id 20181230054528.GB608@paquier.xyz
Whole thread Raw
In response to Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On Sat, Dec 29, 2018 at 04:31:11PM +0100, Peter Eisentraut wrote:
> On 21/12/2018 05:05, Michael Paquier wrote:
>> -    (errmsg("pg_stop_backup cleanup done, waiting for required WAL segments to be archived")));
>> +    (errmsg("waiting for required WAL segments to be archived")));
>
> I think this loses the context that this is happening during a base
> backup.  I'd keep something like "base backup done, waiting ...".

Okay, point taken.  I'll send a patch after answering to your other
comments.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: plpgsql plugin - stmt_beg/end is not called for top level blockof statements
Next
From: Michael Paquier
Date:
Subject: Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup