Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup
Date
Msg-id 8f34fead-b245-3f9a-baeb-97100ef1e0f8@2ndquadrant.com
Whole thread Raw
In response to Clean up some elog messages and comments for do_pg_stop_backup anddo_pg_start_backup  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 21/12/2018 05:05, Michael Paquier wrote:
> -                        (errmsg("pg_stop_backup cleanup done, waiting for required WAL segments to be archived")));
> +                        (errmsg("waiting for required WAL segments to be archived")));

I think this loses the context that this is happening during a base
backup.  I'd keep something like "base backup done, waiting ...".

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Clean up some elog messages and comments for do_pg_stop_backupand do_pg_start_backup
Next
From: Tom Lane
Date:
Subject: Re: Garbage contents after running autoconf 2.69