Re: ALTER INDEX ... ALTER COLUMN not present in dump - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: ALTER INDEX ... ALTER COLUMN not present in dump
Date
Msg-id 20181116133103.GA3427@paquier.xyz
Whole thread Raw
In response to Re: ALTER INDEX ... ALTER COLUMN not present in dump  (Michael Paquier <michael@paquier.xyz>)
Responses Re: ALTER INDEX ... ALTER COLUMN not present in dump
List pgsql-bugs
On Fri, Nov 16, 2018 at 05:32:52PM +0900, Michael Paquier wrote:
> And here you go as attached.  Looking closer, in v10 and older versions,
> ALTER INDEX SET STATISTICS is able to work as it is an alias of ALTER
> TABLE.  The attached patch does not bother generating the ALTER INDEX
> queries for v10 and older and feeds queries with empty strings.  Perhaps
> we should support that case?  Or the lack of complains would be an
> argument sufficient to care only about v11 and newer versions?  I would
> tend to think that supporting only v11 and above is enough.  Thoughts
> are welcome.

+       appendPQExpBuffer(q, "ALTER COLUMN %s ",
+                         indstatcolsarray[j])

This forgot a wrapping with fmtId().  Friday hits hard..
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: Michael Paquier
Date:
Subject: Re: ALTER INDEX ... ALTER COLUMN not present in dump
Next
From: Andrey
Date:
Subject: select (fn()).* executes function multiple times