Re: ALTER INDEX ... ALTER COLUMN not present in dump - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: ALTER INDEX ... ALTER COLUMN not present in dump
Date
Msg-id 20181116083252.GF6613@paquier.xyz
Whole thread Raw
In response to Re: ALTER INDEX ... ALTER COLUMN not present in dump  (Michael Paquier <michael@paquier.xyz>)
Responses Re: ALTER INDEX ... ALTER COLUMN not present in dump  (Michael Paquier <michael@paquier.xyz>)
List pgsql-bugs
On Fri, Nov 16, 2018 at 09:45:05AM +0900, Michael Paquier wrote:
> A good thing is that when ALTER INDEX .. SET STATISTICS is applied on an
> index of a partitioned table, the statement is not cascaded to the
> existing partitions.  We may want in the future to support ONLY and make
> the inheritance automatic.  But that's another topic, and the fix for
> v11 should be chirurgical.

And here you go as attached.  Looking closer, in v10 and older versions,
ALTER INDEX SET STATISTICS is able to work as it is an alias of ALTER
TABLE.  The attached patch does not bother generating the ALTER INDEX
queries for v10 and older and feeds queries with empty strings.  Perhaps
we should support that case?  Or the lack of complains would be an
argument sufficient to care only about v11 and newer versions?  I would
tend to think that supporting only v11 and above is enough.  Thoughts
are welcome.
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #15509: Pg_Dump failed if Database name contains non ascii characters
Next
From: Michael Paquier
Date:
Subject: Re: ALTER INDEX ... ALTER COLUMN not present in dump