Postgres Pro
Downloads
Home   >   mailing lists

Re: Segfault when creating partition with a primary key and sql_droptrigger exists - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Segfault when creating partition with a primary key and sql_droptrigger exists
Date
Msg-id 20181004152229.elsrlz2bfigl5t5x@alvherre.pgsql
Whole thread Raw
In response to Re: Segfault when creating partition with a primary key and sql_droptrigger exists  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Segfault when creating partition with a primary key and sql_droptrigger exists  (Dmitry Dolgov <9erthalion6@gmail.com>)
Re: Segfault when creating partition with a primary key and sql_droptrigger exists  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view 
I admit I'm surprised that your patch fixes the bug.  sql_drop was added
before the command-stashing was added for pg_event_trigger_ddl_commands
was added, and sql_drop only processes objects from the list passed to
performMultipleDeletions, so adding the EventTriggerAlterTableStart() /
End() calls should not affect it ... evidently I must be missing
something here.

Still looking.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Multiple primary key on partition table?
Next
From: Konstantin Knizhnik
Date:
Subject: Re: [HACKERS] Secondary index access optimizations