Re: pgsql: Fix configure's snprintf test so it exposes HP-UX bug. - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Fix configure's snprintf test so it exposes HP-UX bug.
Date
Msg-id 20180824054824.o6sc6jhcbfnwdk4o@alap3.anarazel.de
Whole thread Raw
In response to pgsql: Fix configure's snprintf test so it exposes HP-UX bug.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Fix configure's snprintf test so it exposes HP-UX bug.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 2018-08-17 14:38:41 +0000, Tom Lane wrote:
> Fix configure's snprintf test so it exposes HP-UX bug.
> 
> Since commit e1d19c902, buildfarm member gharial has been failing with
> symptoms indicating that snprintf sometimes returns -1 for buffer
> overrun, even though it passes the added configure check.  Some
> google research suggests that this happens only in limited cases,
> such as when the overrun happens partway through a %d item.  Adjust
> the configure check to exercise it that way.  Since I'm now feeling
> more paranoid than I was before, also make the test explicitly verify
> that the buffer doesn't get physically overrun.
> 
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/9bed827b18cc4f27fb7cd7c02ad301519eca6d29
> 
> Modified Files
> --------------
> config/c-library.m4 | 11 ++++++++---
> configure           |  9 ++++++---
> 2 files changed, 14 insertions(+), 6 deletions(-)

Afaictl this does not seem to have done the trick, gharial is still red?

Greetings,

Andres Freund


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Introduce minimal C99 usage to verify compiler support.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Fix configure's snprintf test so it exposes HP-UX bug.