Re: print_path is missing GatherMerge and CustomScan support - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: print_path is missing GatherMerge and CustomScan support
Date
Msg-id 20180719005808.GB3411@paquier.xyz
Whole thread Raw
In response to Re: print_path is missing GatherMerge and CustomScan support  (Michael Paquier <michael@paquier.xyz>)
Responses Re: print_path is missing GatherMerge and CustomScan support  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
On Wed, Jul 18, 2018 at 03:22:02PM +0900, Michael Paquier wrote:
> Good catch.  Those should be backpatched.  While I am looking at this
> stuff, I have noticed that pathnode.c/reparameterize_path_by_child uses
> T_MergeAppend and not T_MergeAppendPath.

Okay, I have checked the full list of path nodes and the two ones you
mentioned are the only missing.  CustomPath has been added in 9.5, so
this has been patched down to this version.  GatherMergePath is new as
of 10.

The order of the items in print_path and nodes.h was a bit messed up as
well which made unnecessarily harder to check the list, so I fixed the
order at the same time to ease future lookups and back-patching effort.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "Jamison, Kirk"
Date:
Subject: RE: Recovery performance of standby for multiple concurrenttruncates on large tables
Next
From: Michael Paquier
Date:
Subject: Re: YA race condition in 001_stream_rep.pl (was Re: pgsql: Allowusing the updated tuple while moving it to a different par)