Re: print_path is missing GatherMerge and CustomScan support - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: print_path is missing GatherMerge and CustomScan support
Date
Msg-id CAD21AoBd6Fd9q1bBeF_ep3VdqG6NDDN6sQAu2btjOjNnsNaoyg@mail.gmail.com
Whole thread Raw
In response to Re: print_path is missing GatherMerge and CustomScan support  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Thu, Jul 19, 2018 at 9:58 AM, Michael Paquier <michael@paquier.xyz> wrote:
> On Wed, Jul 18, 2018 at 03:22:02PM +0900, Michael Paquier wrote:
>> Good catch.  Those should be backpatched.  While I am looking at this
>> stuff, I have noticed that pathnode.c/reparameterize_path_by_child uses
>> T_MergeAppend and not T_MergeAppendPath.
>
> Okay, I have checked the full list of path nodes and the two ones you
> mentioned are the only missing.  CustomPath has been added in 9.5, so
> this has been patched down to this version.  GatherMergePath is new as
> of 10.
>
> The order of the items in print_path and nodes.h was a bit messed up as
> well which made unnecessarily harder to check the list, so I fixed the
> order at the same time to ease future lookups and back-patching effort.

Thank you for committing the patch!

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: documentation about explicit locking
Next
From: Heikki Linnakangas
Date:
Subject: Re: [PATCH] Find additional connection service files inpg_service.conf.d directory