Re: print_path is missing GatherMerge and CustomScan support - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: print_path is missing GatherMerge and CustomScan support
Date
Msg-id 20180718062202.GC8565@paquier.xyz
Whole thread Raw
In response to print_path is missing GatherMerge and CustomScan support  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: print_path is missing GatherMerge and CustomScan support  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
Re: print_path is missing GatherMerge and CustomScan support  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Wed, Jul 18, 2018 at 02:35:23PM +0900, Masahiko Sawada wrote:
> Hi,
>
> While debugging planner I realized that print_path() function is not
> aware of both GatherMerge path and CustomScan path. Attached small
> patch fixes it.

Good catch.  Those should be backpatched.  While I am looking at this
stuff, I have noticed that pathnode.c/reparameterize_path_by_child uses
T_MergeAppend and not T_MergeAppendPath.

--- a/src/backend/optimizer/util/pathnode.c
+++ b/src/backend/optimizer/util/pathnode.c
@@ -3817,7 +3817,7 @@ do { \
            }
            break;

-       case T_MergeAppend:
+       case T_MergeAppendPath:
            {
                 MergeAppendPath *mapath

This is new as of f49842d1 in v11.  Robert, Ashutosh, am I missing
something?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "Tsunakawa, Takayuki"
Date:
Subject: RE: [bug fix] Produce a crash dump before main() on Windows
Next
From: Michael Paquier
Date:
Subject: Re: [bug fix] Produce a crash dump before main() on Windows