Re: [PoC PATCH] Parallel dump to /dev/null - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PoC PATCH] Parallel dump to /dev/null
Date
Msg-id 20180305165609.kq5y7uzy64o45vsg@alvherre.pgsql
Whole thread Raw
In response to Re: [PoC PATCH] Parallel dump to /dev/null  (Michael Banck <michael.banck@credativ.de>)
Responses Re: [PoC PATCH] Parallel dump to /dev/null  (Michael Banck <michael.banck@credativ.de>)
Re: [PoC PATCH] Parallel dump to /dev/null  (Christoph Berg <christoph.berg@credativ.de>)
List pgsql-hackers
I made a few amendments (here's v5) and was ready to push, when I
noticed that _StartBlobs() does not seem to be doing the right thing.
Did you test this with a few large objects?

The reason I noticed is I wondered about the amount of open() calls
(plus zlib function calls) we would save by keeping an FD open to
/dev/null, rather than opening it over and over for each object -- ie.,
maybe not touch setFilePath() at all, if possible.  That looks perhaps
too invasive, so maybe not.  But do audit other callsites that may open
files.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: 2018-03 CFM
Next
From: Arthur Zakirov
Date:
Subject: Re: [HACKERS] Another oddity in handling of WCO constraints inpostgres_fdw