Hi Alvaro,
Am Montag, den 05.03.2018, 12:48 -0300 schrieb Alvaro Herrera:
> Please make ctx->discard a bool, not an int.
Ok, done so now. I forgot to mention that in the earlier resubmission,
but I had a look at the other pg_backup_*.c files and isSpecialScript
and hasSeek were ints as well, so I opted for that.
> You can initialize it like this:
> ctx->discard = strcmp(ctx->directory, DEVNULL) == 0;
Thanks, changed it thusly.
> Why do you change the mode to create directory to 0711 from 0700?
Oh wow, that was either a mistype in vim or a very old test hack, thanks
for spotting it.
> You have a cuddled "else" in the last hunk. Please uncuddle.
Done so now, hopefully.
Thanks again for the review, a new version is attached.
Michael
--
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax: +49 2166 9901-100
Email: michael.banck@credativ.de
credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
