Re: [PoC PATCH] Parallel dump to /dev/null - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PoC PATCH] Parallel dump to /dev/null
Date
Msg-id 20180305154826.7c5ie2c37qx2s2xv@alvherre.pgsql
Whole thread Raw
In response to Re: [PoC PATCH] Parallel dump to /dev/null  (Michael Banck <michael.banck@credativ.de>)
Responses Re: [PoC PATCH] Parallel dump to /dev/null  (Michael Banck <michael.banck@credativ.de>)
List pgsql-hackers
Please make ctx->discard a bool, not an int.

You can initialize it like this:
    ctx->discard = strcmp(ctx->directory, DEVNULL) == 0;

Why do you change the mode to create directory to 0711 from 0700?

You have a cuddled "else" in the last hunk.  Please uncuddle.



-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: planner failure with ProjectSet + aggregation + parallel query
Next
From: Vik Fearing
Date:
Subject: Re: PATCH: psql tab completion for SELECT