Re: [HACKERS] Another oddity in handling of WCO constraints inpostgres_fdw - Mailing list pgsql-hackers

From Arthur Zakirov
Subject Re: [HACKERS] Another oddity in handling of WCO constraints inpostgres_fdw
Date
Msg-id 20180305165708.GA24246@zakirov.localdomain
Whole thread Raw
In response to Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
List pgsql-hackers
On Mon, Mar 05, 2018 at 09:44:37PM +0900, Etsuro Fujita wrote:
> I rebased the patch over HEAD.  Please find attached an updated patch.

Thank you!

IMHO, it is worth to add more explaining comment into
deparseReturningList, why it is necessary to merge WCO attributes to
RETURNING clause. You already noted it in the thread. I think it could
confuse someone who not very familiar how RETURNING is related with WITH
CHECK OPTION.

-- 
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [PoC PATCH] Parallel dump to /dev/null
Next
From: Alex Kane
Date:
Subject: Re: All Taxi Services need Index Clustered Heap Append