Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw
Date
Msg-id 5A9D3BB5.7090801@lab.ntt.co.jp
Whole thread Raw
In response to Re: [HACKERS] Another oddity in handling of WCO constraints inpostgres_fdw  (Arthur Zakirov <a.zakirov@postgrespro.ru>)
Responses Re: [HACKERS] Another oddity in handling of WCO constraints inpostgres_fdw
List pgsql-hackers
Tree view 
Hi Arthur,

(2018/03/03 18:51), Arthur Zakirov wrote:
> On Wed, Feb 28, 2018 at 05:22:42PM +0900, Etsuro Fujita wrote:
>> I rebased the patch over HEAD and revised comments/docs a little bit. Please
>> find attached a new version of the patch.
>
> I've reviewed the patch.
>
> The code is good, clear and it is pretty small. There are documentation
> fixes and additional regression tests.
>
> Unfortunately the patch is outdated and it needs rebasing. Outdated
> files are regression tests files.
>
> After rebasing regression tests they pass.

I rebased the patch over HEAD.  Please find attached an updated patch.

Thank you for the review!

Best regards,
Etsuro Fujita
Attachment

pgsql-hackers by date:

Previous
From: tushar
Date:
Subject: Re: Server Crash while executing pg_replication_slot_advance (secondtime)
Next
From: "Andreas 'ads' Scherbaum"
Date:
Subject: Re: [PATCH] Find additional connection service files inpg_service.conf.d directory