Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementationof strlen. - Mailing list pgsql-committers

On 2017-10-10 13:53:15 -0700, Andres Freund wrote:
> On 2017-10-10 16:51:39 -0400, Tom Lane wrote:
> > Andres Freund <andres@anarazel.de> writes:
> > > As far as I can tell it's still somehow using a configure from before
> > > the last commits:
> > 
> > No, it's pilot error.  The AC_CHECK_FUNCS call you added strnlen to
> > is only executed if
> > AS_IF([test "$enable_thread_safety" = yes -a "$PORTNAME" != "win32"],
> 
> Dear god, I'm daft. Dear god, m4 is a horrible lanuagage.

Here's a fix. Not quite sure whether we really need the
HAVE_DECL_STRNLEN test, added it for symmetry.

Afaict windows "always" had strnlen, so no need to meddle with the
windows build.

Will eat lunch and push, even if there's some futher adjustments, I'd
like to get Andrew's animals green again.

Greetings,

Andres Freund

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers