Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen. - Mailing list pgsql-committers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.
Date
Msg-id 31930.1507673415@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementationof strlen.  (Andres Freund <andres@anarazel.de>)
Responses Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementationof strlen.  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> Here's a fix. Not quite sure whether we really need the
> HAVE_DECL_STRNLEN test, added it for symmetry.

LGTM.  I think the DECL test is a good idea; the system definition
might be a macro or otherwise weird, in which case we'd cause problems
if we write an extern definition anyway.
        regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementationof strlen.
Next
From: Andres Freund
Date:
Subject: [COMMITTERS] pgsql: Rewrite strnlen replacement implementation from 8a241792f96.