Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementationof strlen. - Mailing list pgsql-committers

From Andres Freund
Subject Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementationof strlen.
Date
Msg-id 20171010223951.cn2oaijecml2s7ro@alap3.anarazel.de
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 2017-10-10 18:10:15 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Here's a fix. Not quite sure whether we really need the
> > HAVE_DECL_STRNLEN test, added it for symmetry.
> 
> LGTM.

Thanks for checking.


> I think the DECL test is a good idea; the system definition
> might be a macro or otherwise weird, in which case we'd cause problems
> if we write an extern definition anyway.

I was thinking about protecting it with HAVE_STRNLEN rather than not
protecting it at all. But this works, so whatever ;)

Greetings,

Andres Freund


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: [COMMITTERS] pgsql: Rewrite strnlen replacement implementation from 8a241792f96.
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Regenerate configure script.