On 10/10/2017 03:48 PM, Andres Freund wrote:
> On 2017-10-09 23:33:36 -0400, Andrew Dunstan wrote:
>>
>> On 10/09/2017 07:15 PM, Andres Freund wrote:
>>> Hi Andrew,
>>>
>>> On 2017-10-09 22:22:04 +0000, Andres Freund wrote:
>>>> Add pg_strnlen() a portable implementation of strlen.
>>>>
>>>> As the OS version is likely going to be more optimized, fall back to
>>>> it if available, as detected by configure.
>>> I'm a bit confused, frogmouth
>>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=frogmouth&dt=2017-10-09%2022%3A30%3A41
>>> shows that it compiled the new code, but the configure output doesn't
>>> show it ran through the new configure test. Additionally, without the
>>> the config define, this should result in the replacement being
>>> used. Which doesn't seem to be the case either.
>>>
>>> Kinda sounds like this used some halfway outdated build or such?
>>>
>>
>>
>> frogmouth is using some code not yet released that makes the config
>> cache persistent. I just identified and fixed a stupid bug in the code
>> that obsoletes the cache, and I have removed frogmouth's cache file and
>> set it running again, so we'll see if that fixes things.
> As far as I can tell it's still somehow using a configure from before
> the last commits:
> https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=frogmouth&dt=2017-10-10%2018%3A35%3A06&stg=configure
>
> Note that it's not running the new test.
>
> (there's definitely fixes to be made to where strnlen's replacement is
> located, but regardless, this needs to be fixed too)
>
This test is governed by the test at line 946 of configure.in. You need
to move it somewhere else.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
