Re: [HACKERS] an outdated comment for hash_seq_init. - Mailing list pgsql-hackers

From Kyotaro HORIGUCHI
Subject Re: [HACKERS] an outdated comment for hash_seq_init.
Date
Msg-id 20170426.173128.180695546.horiguchi.kyotaro@lab.ntt.co.jp
Whole thread Raw
In response to Re: [HACKERS] an outdated comment for hash_seq_init.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
At Tue, 25 Apr 2017 11:00:16 -0400, Robert Haas <robertmhaas@gmail.com> wrote in
<CA+TgmobU=F1JtGZ+bL91D7sE2+cBybmJ+WMQdmTT0cyV2dvO0Q@mail.gmail.com>
> On Mon, Apr 24, 2017 at 3:55 AM, Kyotaro HORIGUCHI
> <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> > While I looked into dynahash.c, I found that the following
> > sentense became outdated by 5dfc198. The commit removed the only
> > usage of hash_freeze().
> >
> >> * NOTE: it is possible to use hash_seq_init/hash_seq_search without any
> >> * worry about hash_seq_term cleanup, if the hashtable is first locked against
> >> * further insertions by calling hash_freeze.  This is used by nodeAgg.c,
> >> * wherein it is inconvenient to track whether a scan is still open, and
> >> * there's no possibility of further insertions after readout has begun.
> >
> > The attached patch removes the sentence begins with "This is used
> > by..".
> 
> Committed.

Thanks.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center




pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: [HACKERS] statement_timeout is not working as expected withpostgres_fdw
Next
From: David Rowley
Date:
Subject: Re: [HACKERS] Foreign Join pushdowns not working properly for outer joins