Re: [HACKERS] an outdated comment for hash_seq_init. - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] an outdated comment for hash_seq_init.
Date
Msg-id CA+TgmobU=F1JtGZ+bL91D7sE2+cBybmJ+WMQdmTT0cyV2dvO0Q@mail.gmail.com
Whole thread Raw
In response to [HACKERS] an outdated comment for hash_seq_init.  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: [HACKERS] an outdated comment for hash_seq_init.
List pgsql-hackers
On Mon, Apr 24, 2017 at 3:55 AM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> While I looked into dynahash.c, I found that the following
> sentense became outdated by 5dfc198. The commit removed the only
> usage of hash_freeze().
>
>> * NOTE: it is possible to use hash_seq_init/hash_seq_search without any
>> * worry about hash_seq_term cleanup, if the hashtable is first locked against
>> * further insertions by calling hash_freeze.  This is used by nodeAgg.c,
>> * wherein it is inconvenient to track whether a scan is still open, and
>> * there's no possibility of further insertions after readout has begun.
>
> The attached patch removes the sentence begins with "This is used
> by..".

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] PG 10 release notes
Next
From: Daniel Gustafsson
Date:
Subject: Re: [HACKERS] A note about debugging TAP failures