Re: [HACKERS] A note about debugging TAP failures - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [HACKERS] A note about debugging TAP failures
Date
Msg-id 112CB42A-C408-4D3E-9B8B-CBDE939CD7EC@yesql.se
Whole thread Raw
In response to Re: [HACKERS] A note about debugging TAP failures  (Craig Ringer <craig.ringer@2ndquadrant.com>)
Responses Re: [HACKERS] A note about debugging TAP failures  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
> On 24 Apr 2017, at 17:19, Craig Ringer <craig.ringer@2ndquadrant.com> wrote:
>
> On 24 April 2017 at 20:01, Daniel Gustafsson <daniel@yesql.se> wrote:
>
>> I’m np Perl expert though so there might be better/cleaner ways to achieve
>> this, in testing it seems to work though.  rmtree() is supported at least since
>> Perl 5.6 from what I can see.
>
> I'd rather just have the 'make' target nuke the relevant tmp_check dir
> before rerunning the tests. Right now it just deletes the logs.

Makes sense, assuming a “clean slate” to run on seems a reasonable assumption
for the test and it makes for simpler code in PostgresNode.  Updated the patch
which now have static datadir names; retains on PG_TESTS_NOCLEAN or any kind of
test failure; and allows for cleaning datadirs without having to use make clean
(seems the wrong size hammer for that nail).

cheers ./daniel


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] an outdated comment for hash_seq_init.
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] PG 10 release notes