Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c - Mailing list pgsql-committers

From Stephen Frost
Subject Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c
Date
Msg-id 20170316033949.GI9812@tamriel.snowman.net
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> I wrote:
> > Stephen Frost <sfrost@snowman.net> writes:
> >> Clean up overly paranoid checks in mac8.c
>
> > termite thinks this wasn't quite right.
>
> On looking at it a bit more closely, I think you've forgotten that
> "char" is signed on some platforms and unsigned on others.  I'd
> suggest putting explicit casts to unsigned char into these tests.

Right, going through it now and adjusting things to be more careful
about that.

Thanks!

Stephen

Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c
Next
From: Stephen Frost
Date:
Subject: [COMMITTERS] pgsql: Be more careful about signed vs. unsigned char