Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c - Mailing list pgsql-committers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c
Date
Msg-id 20683.1489635496@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c
List pgsql-committers
I wrote:
> Stephen Frost <sfrost@snowman.net> writes:
>> Clean up overly paranoid checks in mac8.c

> termite thinks this wasn't quite right.

On looking at it a bit more closely, I think you've forgotten that
"char" is signed on some platforms and unsigned on others.  I'd
suggest putting explicit casts to unsigned char into these tests.

            regards, tom lane


pgsql-committers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c
Next
From: Stephen Frost
Date:
Subject: Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c