[COMMITTERS] pgsql: Be more careful about signed vs. unsigned char - Mailing list pgsql-committers

Be more careful about signed vs. unsigned char

The buildfarm has reminded me that not all systems consider char to be
signed and we need to be explicit.  Adjust the various bits of mac8.c
for what we intend, mostly using casts to unsigned char as suggested by
Tom, and adjust the tests for valid input accordingly.  Explicitly make
the hexlookup table signed as it's useful to use -1 there to indicate an
invalid value.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cccbddeb1483b85f1853a29dc3b6464647b91eee

Modified Files
--------------
src/backend/utils/adt/mac8.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)