Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_filedump 9.3: checksums (and a few other fixes) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pg_filedump 9.3: checksums (and a few other fixes)
Date
Msg-id 20130610151659.GF15368@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: pg_filedump 9.3: checksums (and a few other fixes)  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: pg_filedump 9.3: checksums (and a few other fixes)
List pgsql-hackers
Tree view 
Jeff Davis wrote:

> I was hesitant to do too much interpretation of the bits. Do you think
> it would be better to just remove the test for XMAX_SHR_LOCK?

I don't know, but then I'm biased because I know what that specific bit
combination means.  I guess someone that doesn't know is going to be
surprised by seeing both lock strength bits together .. but maybe
they're just going to have a look at htup_details.h and instantly
understand what's going on.  Not sure how likely that is.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: erroneous restore into pg_catalog schema
Next
From: Dimitri Fontaine
Date:
Subject: Re: erroneous restore into pg_catalog schema