Tom Lane wrote:
> Greg Stark <gsstark@mit.edu> writes:
> > On Tue, Aug 4, 2009 at 12:18 AM, Tom Lane<tgl@sss.pgh.pa.us> wrote:
> >> One other stylistic gripe: I don't much like inserting a GUC variable
> >> definition into builtins.h --- that file has traditionally only
> >> contained function extern declarations. �The best alternative I can
> >> think of is to move the bytea-related stuff into a new include file
> >> include/utils/bytea.h. �Has anyone got an objection or a better idea?
>
> > The other guc that controls default i/o formats for a data type is
> > DateStyle. I can't say I expected to find that in miscadmin.h though.
> > Perhaps move both of them into a utils/adt.h or something like that?
>
> Hmm, actually now that you mention it there's a bunch of GUC variables
> in miscadmin.h. Surprise factor aside, I'm inclined to just shove
> bytea_output in there along with DateStyle/IntervalStyle/etc.
I vote for a new bytea.h file that does not slurp in byteain/byteaout,
to avoid breaking 3rd party code. miscadmin.h seems the worst solution,
since it's already included in 210 other files.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
