Re: Solve a problem of LC_TIME of windows. - Mailing list pgsql-hackers

From ITAGAKI Takahiro
Subject Re: Solve a problem of LC_TIME of windows.
Date
Msg-id 20090107140111.810A.52131E4D@oss.ntt.co.jp
Whole thread Raw
In response to Re: [PATCHES] Solve a problem of LC_TIME of windows.  (Hiroshi Inoue <inoue@tpf.co.jp>)
Responses Re: Solve a problem of LC_TIME of windows.  (Alvaro Herrera <alvherre@commandprompt.com>)
Re: Solve a problem of LC_TIME of windows.  (Magnus Hagander <magnus@hagander.net>)
Re: Solve a problem of LC_TIME of windows.  (Hiroshi Inoue <inoue@tpf.co.jp>)
Re: Solve a problem of LC_TIME of windows.  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Hiroshi Inoue <inoue@tpf.co.jp> wrote:

> Seems LC_CTYPE and LC_TIME should be convertible even though we use
> wcsftime (which internally calls strftime?).

Ok, wcsftime() requries both LC_TIME and LC_CTYPE are the same setting
(at least encoding) on Windows.

The attached patch is an updated version to fix cache_locale_time().
Now it sets LC_TIME and LC_CTYPE to the specified locale and restore
them at end of the function. I tested the patch on Windows XP Japanese
Edition (SJIS) with UTF-8 and EUCJP databases, and worked expectedly.

"#ifdef WIN32" codes seems to be ugly in the patch,
but I have no other idea...

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center


Attachment

pgsql-hackers by date:

Previous
From: "Robert Haas"
Date:
Subject: Re: Proposed Patch to Improve Performance of Multi-BatchHash Join for Skewed Data Sets
Next
From: Bruce Momjian
Date:
Subject: Do we still need constraint_exclusion?