Re: Solve a problem of LC_TIME of windows. - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Solve a problem of LC_TIME of windows.
Date
Msg-id 4964AD2D.7060009@hagander.net
Whole thread Raw
In response to Re: Solve a problem of LC_TIME of windows.  (ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
Responses Re: Solve a problem of LC_TIME of windows.
List pgsql-hackers
ITAGAKI Takahiro wrote:
> Hiroshi Inoue <inoue@tpf.co.jp> wrote:
> 
>> Seems LC_CTYPE and LC_TIME should be convertible even though we use
>> wcsftime (which internally calls strftime?).
> 
> Ok, wcsftime() requries both LC_TIME and LC_CTYPE are the same setting
> (at least encoding) on Windows.
> 
> The attached patch is an updated version to fix cache_locale_time().
> Now it sets LC_TIME and LC_CTYPE to the specified locale and restore
> them at end of the function. I tested the patch on Windows XP Japanese
> Edition (SJIS) with UTF-8 and EUCJP databases, and worked expectedly.
> 
> "#ifdef WIN32" codes seems to be ugly in the patch,
> but I have no other idea...

Hmm. Is this actually cleaner than using the original method as
suggested? Because if I understand things right, that version did *not*
require the setting of LC_CTYPE? (this is the version that uses strftime
and does two conversions)

//Magnus



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Solve a problem of LC_TIME of windows.
Next
From: Tom Lane
Date:
Subject: Re: error code 25001