Re: [Review] pgbench duration option - Mailing list pgsql-hackers

From ITAGAKI Takahiro
Subject Re: [Review] pgbench duration option
Date
Msg-id 20080908174150.9839.52131E4D@oss.ntt.co.jp
Whole thread Raw
In response to Re: [Review] pgbench duration option  ("Brendan Jurd" <direvus@gmail.com>)
Responses Re: [Review] pgbench duration option  ("Brendan Jurd" <direvus@gmail.com>)
Re: [Review] pgbench duration option  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Re: [Review] pgbench duration option  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
Here is a revised version of the pgbench duration patch.
I merged some comments from Brendan and gnari.

"Brendan Jurd" <direvus@gmail.com> wrote:

> >> Wouldn't this be better written as:
> >>   if ((duration > 0 && timer_exceeded) || st->cnt >= nxacts)
> >
> > sorry, but these do not lok as the same thing to me.
> > gnari

I used this condition expression here:
       if ((st->cnt >= nxacts && duration <= 0) || timer_exceeded)

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center


Attachment

pgsql-hackers by date:

Previous
From: Zdenek Kotala
Date:
Subject: Re: Prototype: In-place upgrade v02
Next
From: Heikki Linnakangas
Date:
Subject: Re: Prototype: In-place upgrade v02