Re: [Review] pgbench duration option - Mailing list pgsql-hackers

From Brendan Jurd
Subject Re: [Review] pgbench duration option
Date
Msg-id 37ed240d0809081140p7a2529efsfdf064ef7e38d90d@mail.gmail.com
Whole thread Raw
In response to Re: [Review] pgbench duration option  (ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
List pgsql-hackers
On Mon, Sep 8, 2008 at 6:59 PM, ITAGAKI Takahiro
<itagaki.takahiro@oss.ntt.co.jp> wrote:
> Here is a revised version of the pgbench duration patch.
> I merged some comments from Brendan and gnari.
>

The changes look good.  I tried out the new v3 patch and didn't
encounter any problems.

One last minor quibble - I think the wording in the documentation is
still a little bit awkward:
  In the first place, <emphasis>never</> believe any test that runs  for only a few seconds.  Use the <literal>-t</> or
<literal>-T</>
setting enough  to make the run last at least a few minutes, so as to average out noise.

This reads better IMHO if you simply omit the word "enough".

Cheers,
BJ


pgsql-hackers by date:

Previous
From: "Brendan Jurd"
Date:
Subject: Re: [PATCHES] to_date() validation
Next
From: Simon Riggs
Date:
Subject: Re: Synchronous Log Shipping Replication