Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update
Date
Msg-id 200607260359.k6Q3xKT24184@momjian.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update  (Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>)
List pgsql-hackers
Tom Lane wrote:
> Joshua Reich <josh@root.net> writes:
> >> The problem is that there are new functions in cube.sql, so the output 
> >> is now different and breaks the diff (to state the obvious).
> 
> Actually, the new theory on this is that you should explicitly create
> a shell type first:
> 
>     CREATE TYPE cube;
> 
> and then create the functions, and then make the type "for real".
> 
> This will still involve a change in the earthdistance expected
> output (down to zero expected NOTICEs) but if we're gonna fix it
> then let's fix it right.

OK, I will wait for the next patch.  Funny I tested the cube regression
test, but not earthdistance.

--  Bruce Momjian   bruce@momjian.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update
Next
From: ITAGAKI Takahiro
Date:
Subject: Re: Resurrecting per-page cleaner for btree