Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update - Mailing list pgsql-hackers

From Stefan Kaltenbrunner
Subject Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update
Date
Msg-id 44C7292C.5020909@kaltenbrunner.cc
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian wrote:
> Tom Lane wrote:
>> Joshua Reich <josh@root.net> writes:
>>>> The problem is that there are new functions in cube.sql, so the output 
>>>> is now different and breaks the diff (to state the obvious).
>> Actually, the new theory on this is that you should explicitly create
>> a shell type first:
>>
>>     CREATE TYPE cube;
>>
>> and then create the functions, and then make the type "for real".
>>
>> This will still involve a change in the earthdistance expected
>> output (down to zero expected NOTICEs) but if we're gonna fix it
>> then let's fix it right.
> 
> OK, I will wait for the next patch.  Funny I tested the cube regression
> test, but not earthdistance.

FYI: the buildfarm-script has a "no reporting" mode and can use
preexisting sourcetrees - that's what I regulary use to test patches and
modifications to the source.


Stefan


pgsql-hackers by date:

Previous
From: Joachim Wieland
Date:
Subject: Re: [PATCHES] Time zone definitions to config files
Next
From: Tatsuo Ishii
Date:
Subject: pgbench enhancements