Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory
Date
Msg-id 200506061335.j56DZs721211@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory
List pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> >> BTW, I found memory leak in BootStrapXLOG(). The buffer allocated by malloc()
> >> is not free()ed. ISSUE_BOOTSTRAP_MEMORYLEAK in this patch points out it.
> >> (But this leak is not serious, because this function is called only once.)
>
> > Does the following patch fix the memory leak you described?
>
> You realize this is a waste of code, no?  It's not like the bootstrap
> subprocess frees every single bit of memory it ever allocates, and even
> less like it'd be profitable to try to make it do so ... the memory
> will go away anyway when the subprocess exits.

I guess, but the person reported a leak so I figured I would fix it.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Christopher Kings-Lynne
Date:
Subject: Re: lastval()
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory