Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory
Date
Msg-id 25394.1118066190@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> You realize this is a waste of code, no?

> I guess, but the person reported a leak so I figured I would fix it.

I don't really care whether there's a free() there or not --- what
bothers me is that calling it a leak shows a fundamental
misunderstanding of the environment in which that code runs, which
is likely to lead to proposed changes that have less trivial
consequences.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] WAL: O_DIRECT and multipage-writer (+ memory
Next
From: Alvaro Herrera
Date:
Subject: Re: Faster install-sh in C