Re: [HACKERS] Point in Time Recovery - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] Point in Time Recovery
Date
Msg-id 200407291707.i6TH7pK15909@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Point in Time Recovery  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [HACKERS] Point in Time Recovery
List pgsql-patches
Bruce Momjian wrote:
>
> I do think we need a boolean for start/stop of archiving, rather than
> setting it to '' to turn it off.  Tom, I think the group agreed to this
> on clarity grounds.  I would like the server to throw an error if you
> try to turn on archiving and the command is set to ''.

Let me illustrate.  To turn off archiving you have to change:

    #archive_command = ''
    archive_command = 'cp %p /mnt/server/archivedir/%f'

to

    archive_command = ''
    #archive_command = 'cp %p /mnt/server/archivedir/%f'

and if you comment both or neither, you have problems.

With a boolean it would be:

    archive_mode = on
    archive_command = 'cp %p /mnt/server/archivedir/%f'

    archive_mode = off
    archive_command = 'cp %p /mnt/server/archivedir/%f'

Now, if you say people will rarely turn archiving on/off, then one
parameter seems to make more sense.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Andreas Pflug
Date:
Subject: Re: Admin functions contrib
Next
From: Bruce Momjian
Date:
Subject: Re: Admin functions contrib