After no adverse comments from the 'general' list, I have applied this
part of the patch. Should we consider getting rid of the Exec part, so
it just says "Insert/Update" rather than "ExecInsert/ExecUpdate"? I
assume the INSERT/UPDATE is needed because we are reporting trigger
activity.
---------------------------------------------------------------------------
Tom Lane wrote:
> Neil Conway <nconway@klamath.dyndns.org> writes:
>
> ***************
> *** 251,257 ****
> ExecCheckRTPerms(parseTree->rtable, operation);
>
> /*
> ! * Search for subplans and APPEND nodes to check their rangetables.
> */
> ExecCheckPlanPerms(plan, parseTree->rtable, operation);
> }
> --- 251,257 ----
> ExecCheckRTPerms(parseTree->rtable, operation);
>
> /*
> ! * Search for subplans and INSERT nodes to check their rangetables.
> */
> ExecCheckPlanPerms(plan, parseTree->rtable, operation);
> }
> ***************
>
> This comment was right beforehand and is so no longer :-(.
>
> Otherwise I'm okay with this, if we don't mind the probability of
> breaking existing client applications that are looking for ExecAppend:
> messages. One might think that unnecessary changes in common error
> messages are not a good idea until sometime after we've implemented an
> error code facility and given people a chance to move over to looking
> at error codes instead of error strings.
>
> regards, tom lane
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org
>
>
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
