Re: several minor cleanups - Mailing list pgsql-patches

From Tom Lane
Subject Re: several minor cleanups
Date
Msg-id 21216.1024951997@sss.pgh.pa.us
Whole thread Raw
In response to several minor cleanups  (Neil Conway <nconway@klamath.dyndns.org>)
Responses Re: several minor cleanups
Re: several minor cleanups
List pgsql-patches
Neil Conway <nconway@klamath.dyndns.org> writes:

***************
*** 251,257 ****
      ExecCheckRTPerms(parseTree->rtable, operation);

      /*
!      * Search for subplans and APPEND nodes to check their rangetables.
       */
      ExecCheckPlanPerms(plan, parseTree->rtable, operation);
  }
--- 251,257 ----
      ExecCheckRTPerms(parseTree->rtable, operation);

      /*
!      * Search for subplans and INSERT nodes to check their rangetables.
       */
      ExecCheckPlanPerms(plan, parseTree->rtable, operation);
  }
***************

This comment was right beforehand and is so no longer :-(.

Otherwise I'm okay with this, if we don't mind the probability of
breaking existing client applications that are looking for ExecAppend:
messages.  One might think that unnecessary changes in common error
messages are not a good idea until sometime after we've implemented an
error code facility and given people a chance to move over to looking
at error codes instead of error strings.

            regards, tom lane



pgsql-patches by date:

Previous
From: "Zhenbang Wei"
Date:
Subject: [PATCH]errors_zh_TW.properties for JDBC driver
Next
From: Tom Lane
Date:
Subject: Re: show() function