Re: Undocumented feature costs a lot of performance in COPY - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Undocumented feature costs a lot of performance in COPY
Date
Msg-id 200112042007.fB4K72327600@candle.pha.pa.us
Whole thread Raw
In response to Undocumented feature costs a lot of performance in COPY IN  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Undocumented feature costs a lot of performance in COPY IN  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> I would like to change the code to just "if (c == delim[0])",
> which should buy back most of that 20% and make the behavior match the
> documentation.  Question for the list: is this a bad change?  Is anyone
> out there actually using this undocumented behavior?

Yes, please fix it.  In fact, I think we should throw an error if more
than one character is specified as a delimiter.  Saying we ignore
multiple characters in the documentation is not enough when we silently
ignore them in the code.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [GENERAL] Problem (bug?) with like
Next
From: Tom Lane
Date:
Subject: Re: Undocumented feature costs a lot of performance in COPY IN