Re: Undocumented feature costs a lot of performance in COPY IN - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Undocumented feature costs a lot of performance in COPY IN
Date
Msg-id 2993.1007496898@sss.pgh.pa.us
Whole thread Raw
In response to Re: Undocumented feature costs a lot of performance in COPY  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Undocumented feature costs a lot of performance in COPY  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: Undocumented feature costs a lot of performance in  (Tatsuo Ishii <t-ishii@sra.co.jp>)
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Yes, please fix it.  In fact, I think we should throw an error if more
> than one character is specified as a delimiter.  Saying we ignore
> multiple characters in the documentation is not enough when we silently
> ignore them in the code.

Well, it'd be an easy enough addition:
if (strlen(delim) != 1)    elog(ERROR, "COPY delimiter must be a single character");

This isn't multibyte-aware, but then neither is the implementation;
delimiters that are multibyte characters won't work at the moment.

Any comments out there?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Undocumented feature costs a lot of performance in COPY
Next
From: Bruce Momjian
Date:
Subject: Release info updated