Re: Remove sort files - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Remove sort files
Date
Msg-id 200105231940.f4NJeol07251@candle.pha.pa.us
Whole thread Raw
In response to Re: Remove sort files  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Remove sort files  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
> > New command is:
>
> >     snprintf(clear_pg_sorttemp, sizeof(clear_pg_sorttemp),
> >             "rm -f \"%s\"/base/*/pg_sorttemp/*",
> >             DataDir);
>
> I said cd for a reason: if you do it that way, you've cut the maximum
> number of files you can delete by at least an order of magnitude,
> depending on how long DataDir is.
>
> Why do we need per-database sorttemp areas anyway?  Seems better to have
> an installation-wide one.

OK, here is the new code:

    snprintf(clear_pg_sorttemp, sizeof(clear_pg_sorttemp),
            "sh -c '\
            cd \"%s\"/base && \
            ls | while read DIR; \
            do \
                export DIR; \
                (cd \"$DIR\"/pg_sorttemp/ 2>/dev/null && rm -f *); \
            done'",
            DataDir);

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: ANT fix for jar creation
Next
From: Bruce Momjian
Date:
Subject: Re: Remove sort files