Re: Remove sort files - Mailing list pgsql-patches

From Tom Lane
Subject Re: Remove sort files
Date
Msg-id 17261.990648642@sss.pgh.pa.us
Whole thread Raw
In response to Re: Remove sort files  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Remove sort files  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> OK, here is the new code:

>     snprintf(clear_pg_sorttemp, sizeof(clear_pg_sorttemp),
>             "sh -c '\
>             cd \"%s\"/base && \
>             ls | while read DIR; \
>             do \
>                 export DIR; \
>                 (cd \"$DIR\"/pg_sorttemp/ 2>/dev/null && rm -f *); \
>             done'",
>             DataDir);

A readdir() loop would be hardly any longer, and it'd be faster and more
secure.  Among other problems with the above code, we do not prohibit
double-quote in database paths anymore ...

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Remove sort files
Next
From: Tom Lane
Date:
Subject: Re: Remove sort files