Re: Is it really such a good thing for newNode() to be a macro? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Is it really such a good thing for newNode() to be a macro?
Date
Msg-id 18763.1219798656@sss.pgh.pa.us
Whole thread Raw
In response to Re: Is it really such a good thing for newNode() to be a macro?  ("Stephen R. van den Berg" <srb@cuci.nl>)
Responses Re: Is it really such a good thing for newNode() to be a macro?  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
"Stephen R. van den Berg" <srb@cuci.nl> writes:
> b. Create a function newNode() which is declared as inline, which
>    basically gives you the same code as under (a).

I considered that one, but since part of my argument is that inlining
this is a waste of code space, it seems like a better inlining
technology isn't really the answer.

The other two alternatives would force notational changes on all the
callers, which doesn't seem appealing (there are close to 1400 calls
of makeNode() in the backend...)
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Stephen R. van den Berg"
Date:
Subject: Re: Is it really such a good thing for newNode() to be a macro?
Next
From: Alvaro Herrera
Date:
Subject: Re: TODO <-> Commitfest