Re: patch for space around the FragmentDelimiter - Mailing list pgsql-hackers

From Tom Lane
Subject Re: patch for space around the FragmentDelimiter
Date
Msg-id 18181.1235958563@sss.pgh.pa.us
Whole thread Raw
In response to patch for space around the FragmentDelimiter  (Sushant Sinha <sushant354@gmail.com>)
Responses Re: patch for space around the FragmentDelimiter  (Sushant Sinha <sushant354@gmail.com>)
List pgsql-hackers
Sushant Sinha <sushant354@gmail.com> writes:
> FragmentDelimiter is an argument for ts_headline function to separates
> different headline fragments. The default delimiter is " ... ".
> Currently if someone specifies the delimiter as an option to the
> function, no extra space is added around the delimiter. However, it does
> not look good without space around the delimter. 

Maybe not to you, for the particular delimiter you happen to be working
with, but it doesn't follow that spaces are always appropriate.

> Since the option parsing function removes any space around the  given
> value, it is not possible to add any desired space. The attached patch
> adds space when a FragmentDelimiter is specified.

I think this is a pretty bad idea.  Better would be to document how to
get spaces into the delimiter, ie, use double quotes:
... FragmentDelimiter = " ... " ...

Hmm, actually, it looks to me that the documentation already shows this,
in the example of the default values.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: cardinality()
Next
From: Tom Lane
Date:
Subject: Re: WIP: named and mixed notation support