Re: patch for space around the FragmentDelimiter - Mailing list pgsql-hackers

From Sushant Sinha
Subject Re: patch for space around the FragmentDelimiter
Date
Msg-id 1235962771.11108.1.camel@dragflick
Whole thread Raw
In response to Re: patch for space around the FragmentDelimiter  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
yeah you are right. I did not know that you can pass space using double
quotes.

-Sushant.

On Sun, 2009-03-01 at 20:49 -0500, Tom Lane wrote:
> Sushant Sinha <sushant354@gmail.com> writes:
> > FragmentDelimiter is an argument for ts_headline function to separates
> > different headline fragments. The default delimiter is " ... ".
> > Currently if someone specifies the delimiter as an option to the
> > function, no extra space is added around the delimiter. However, it does
> > not look good without space around the delimter. 
> 
> Maybe not to you, for the particular delimiter you happen to be working
> with, but it doesn't follow that spaces are always appropriate.
> 
> > Since the option parsing function removes any space around the  given
> > value, it is not possible to add any desired space. The attached patch
> > adds space when a FragmentDelimiter is specified.
> 
> I think this is a pretty bad idea.  Better would be to document how to
> get spaces into the delimiter, ie, use double quotes:
> 
>     ... FragmentDelimiter = " ... " ...
> 
> Hmm, actually, it looks to me that the documentation already shows this,
> in the example of the default values.
> 
>             regards, tom lane



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Synchronous replication & Hot standby patches
Next
From: Fujii Masao
Date:
Subject: Re: Immediate shutdown and system(3)