Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list
Date
Msg-id 17167.1477335799@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list  (Stephen Frost <sfrost@snowman.net>)
Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list  (Bruce Momjian <bruce@momjian.us>)
Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Fabien COELHO wrote:
>> I find it annoying that "//" comments are not supported, or having to
>> declare variables at the beginning of a block instead of when first used...

> I think some c99 features would be nice (variadic macros for one), but
> those particular two get a big "meh" from me.

Yeah.  Personally, I'd want to continue the rule against // comments just
as a matter of maintaining stylistic consistency.  Code that's got a
random mishmash of // and /* comments looks messy, if you ask me.

An alternative that would be worth considering is to adopt a uniform
rule of // for line-ending comments and /* for all other uses.  We'd
have to teach pgindent about that, and I dunno how hard that is.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Press Release Draft - 2016-10-27 Cumulative Update
Next
From: Tom Lane
Date:
Subject: Re: Press Release Draft - 2016-10-27 Cumulative Update