Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list
Date
Msg-id 20161024195132.GA15185@momjian.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Oct 24, 2016 at 03:03:19PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Fabien COELHO wrote:
> >> I find it annoying that "//" comments are not supported, or having to
> >> declare variables at the beginning of a block instead of when first used...
> 
> > I think some c99 features would be nice (variadic macros for one), but
> > those particular two get a big "meh" from me.
> 
> Yeah.  Personally, I'd want to continue the rule against // comments just
> as a matter of maintaining stylistic consistency.  Code that's got a
> random mishmash of // and /* comments looks messy, if you ask me.
> 
> An alternative that would be worth considering is to adopt a uniform
> rule of // for line-ending comments and /* for all other uses.  We'd
> have to teach pgindent about that, and I dunno how hard that is.

I think it would be easy to teach pg_indent.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: PL/Python adding support for multi-dimensional arrays
Next
From: Peter Eisentraut
Date:
Subject: Re: Rename max_parallel_degree?