Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list
Date
Msg-id 20161024191145.GQ13284@tamriel.snowman.net
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list  (Petr Jelinek <petr@2ndquadrant.com>)
List pgsql-hackers
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Fabien COELHO wrote:
> >> I find it annoying that "//" comments are not supported, or having to
> >> declare variables at the beginning of a block instead of when first used...
>
> > I think some c99 features would be nice (variadic macros for one), but
> > those particular two get a big "meh" from me.
>
> Yeah.  Personally, I'd want to continue the rule against // comments just
> as a matter of maintaining stylistic consistency.  Code that's got a
> random mishmash of // and /* comments looks messy, if you ask me.

+1

> An alternative that would be worth considering is to adopt a uniform
> rule of // for line-ending comments and /* for all other uses.  We'd
> have to teach pgindent about that, and I dunno how hard that is.

I'm not sure it's worth the resulting mess.

Thanks!

Stephen

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Press Release Draft - 2016-10-27 Cumulative Update
Next
From: Victor Wagner
Date:
Subject: Re: Patch: Implement failover on libpq connect level.