Re: commented out code - Mailing list pgsql-hackers

From Tom Lane
Subject Re: commented out code
Date
Msg-id 1711916.1768935331@sss.pgh.pa.us
Whole thread Raw
In response to Re: commented out code  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: commented out code
Re: commented out code
List pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes:
> On 05.12.25 17:38, Heikki Linnakangas wrote:
>> #if 0
>>     Oid      subtype = PG_GETARG_OID(3);
>> #endif
>> 
>> is yet another option. It keeps the indentation, although you won't get 
>> the compiler checking.

> After some reflection, I like this approach.  It keeps the indentation 
> and enables syntax highlighting, so it makes some of these blocks much 
> easier to read.

I think "#ifdef NOT_USED" is our more common style.  +1 other than
that nitpick.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Undefined behavior detected by new clang's ubsan
Next
From: Andres Freund
Date:
Subject: Re: Add missing JIT inline pass for llvm>=17