Re: commented out code - Mailing list pgsql-hackers

On Wed, Jan 21, 2026 at 12:25 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Peter Eisentraut <peter@eisentraut.org> writes:
> > On 05.12.25 17:38, Heikki Linnakangas wrote:
> >> #if 0
> >>     Oid      subtype = PG_GETARG_OID(3);
> >> #endif
> >>
> >> is yet another option. It keeps the indentation, although you won't get
> >> the compiler checking.
>
> > After some reflection, I like this approach.  It keeps the indentation
> > and enables syntax highlighting, so it makes some of these blocks much
> > easier to read.
>
> I think "#ifdef NOT_USED" is our more common style.  +1 other than
> that nitpick.

This resonates with your reply 20 years ago [1]. I would have
preferred to be more specific and say NOT_USED_ARGUMENTS to start with
but something that old is hard to change.

[1] https://www.postgresql.org/message-id/14879.1119968227%40sss.pgh.pa.us

--
Best Wishes,
Ashutosh Bapat